Move HDF4 tests to their own directory #895
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Make sure that all attempts to access the rc file triples check first for triple->host being null.
|
Looks good; I assume the single failure was a one-off. Restarted it. We are at a retreat today, but I'm working my way backwards and want to get a 4.6.1 release out ASAP. |
|
The failure was a single line item out of the various matrices, and appears to have been a timeout pulling down the docker image. A nice side effect of the docker tests, fwiw, is that it is always a 100% clean workspace every time it is run :). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In this PR I move the HDF4 tests into directory hdf4_test.
This also includes the contents of PR #888 in order to pass my CI.
Part of #870.
Fixes #869.
Fixes #744.
Part of #177.